Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GPIO cleanup #2384

Merged
merged 3 commits into from
Oct 22, 2024
Merged

GPIO cleanup #2384

merged 3 commits into from
Oct 22, 2024

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Oct 22, 2024 •
edited
Loading

This PR:

  • Replaces AF arrays with slices. This way we're not limited to 6, and selecting the appropriate signal is somewhat simpler.
  • Replaces &*XXX::PTR with XXX::steal() in gpio.
  • Removes manual register ofsetting now that we have arrays in the PAC.

These changes were part of #2341 but that PR was a bit of a mess. More to come, in smaller bundles this time.

@bugadani bugadani added the skip-changelog No changelog modification needed label Oct 22, 2024
MabezDev
MabezDev approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

jessebraham
jessebraham approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jessebraham jessebraham added this pull request to the merge queue Oct 22, 2024
Merged via the queue into esp-rs:main with commit aec83bd Oct 22, 2024
29 checks passed
@bugadani bugadani deleted the cleanup branch October 22, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MabezDev MabezDev MabezDev approved these changes

@jessebraham jessebraham jessebraham approved these changes

Assignees
No one assigned
Labels
skip-changelog No changelog modification needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bugadani @jessebraham @MabezDev