Fail RMT one-shot transactions if end-marker is missing #2463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
reviewed
Nov 5, 2024
bjoernQ
force-pushed
the
check-rmt-end-marker
branch
from
3221128 to
62bafa1
Compare
|
Seems the failing tests on C6 are not really related to the changed code |
bugadani
reviewed
Nov 5, 2024
bjoernQ
force-pushed
the
check-rmt-end-marker
branch
from
c9f2c60 to
e3588cd
Compare
bugadani
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packagescommand to ensure that all changed code is formatted correctly.CHANGELOG.mdin the proper section.Extra:
Pull Request Details 📖
Description
Closes #2115
Previously we didn't check the (needed) end-marker for single-shot RMT transmissions which ended up getting repeated forever.
Now it's checked and an error is returned if no end-marker is present in the data.
Testing
Changing the example to not include an end-marker should fail