Remove get_ prefix from functions
#2528
Conversation
|
|
| @@ -4,7 +4,7 @@ use core::{cell::UnsafeCell, mem::MaybeUninit}; | |||
|
|
|||
| use embassy_executor::{raw, SendSpawner}; | |||
| use esp_hal::{ | |||
| get_core, | |||
| core, | |||
There was a problem hiding this comment.
Can we drop core() in favour of Cpu::current()?
There was a problem hiding this comment.
Just in this file, or in general?
There was a problem hiding this comment.
In general I think, I don't know if Rust can cope with a function core and the core crate together. Though I guess if it can, we can leave it and come back later.
There was a problem hiding this comment.
Okay will do so in another PR, this one is a bit of a beast and I don't really want to touch it if CI is happy and I don't need to 😅
There was a problem hiding this comment.
Let's make get_core private and use Cpu::current() everywhere (though we don't have to do that here if we can get away with it).
jessebraham
force-pushed
the
fixes/remove-get-prefix
branch
from
188f640 to
bb14edc
Compare
jessebraham
changed the title
jessebraham
changed the title
get_ prefix from functions
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
jessebraham
force-pushed
the
fixes/remove-get-prefix
branch
from
bb14edc to
06f7d17
Compare
I've skipped
xtensa-lxas I don't think we really have any reason to publish a new version of that currently, but can update it as well if requested. Otherwise, I think I got them all (or most of them, at least 😅). Unfortunately had to touch a ton of files in the process, but oh well.Closes #2524