Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix WIFI_EVENT #2817

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Fix WIFI_EVENT #2817

merged 2 commits into from
Dec 16, 2024

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Dec 14, 2024 •
edited
Loading

rust-lang/rust#132975 changed Xtensa c_char to u8, which apparently breaks our builds. This PR properly reimplements what esp-idf does, instead of just adjusting the type of EVT.

@bugadani bugadani added the skip-changelog No changelog modification needed label Dec 14, 2024
@bugadani @Dominaezzz
Update esp-wifi/src/common_adapter/mod.rs
52cdfc4 
Co-authored-by: Dominic Fischer <14130965+Dominaezzz@users.noreply.github.com>
bjoernQ
bjoernQ approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JurajSadel
JurajSadel approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JurajSadel JurajSadel added this pull request to the merge queue Dec 16, 2024
Merged via the queue into esp-rs:main with commit a12e7fe Dec 16, 2024
28 checks passed
@bugadani bugadani deleted the wifi branch December 16, 2024 12:30
hulthe pushed a commit to hulthe/esp-hal that referenced this pull request Jan 4, 2025
@bugadani @Dominaezzz @hulthe
Fix WIFI_EVENT (esp-rs#2817)
a9877c0 
* Fix WIFI_EVENT

* Update esp-wifi/src/common_adapter/mod.rs

Co-authored-by: Dominic Fischer <14130965+Dominaezzz@users.noreply.github.com>

---------

Co-authored-by: Dominic Fischer <14130965+Dominaezzz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dominaezzz Dominaezzz Dominaezzz left review comments

@JurajSadel JurajSadel JurajSadel approved these changes

@bjoernQ bjoernQ bjoernQ approved these changes

Assignees
No one assigned
Labels
skip-changelog No changelog modification needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bugadani @bjoernQ @Dominaezzz @JurajSadel