Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embassy init updates #290

Merged
merged 1 commit into from
Dec 8, 2022
Merged

Embassy init updates #290

merged 1 commit into from
Dec 8, 2022

Conversation

MabezDev
Copy link
Member

@MabezDev MabezDev commented Dec 8, 2022 •
edited
Loading

  • Rename timg feature to timg0 to better reflect which TG is being used
  • Use the time_driver::TimerType in the signature of init to close embassy time driver appears to be unsound #268
  • Update examples
  • Fix CI features
  • Add timg0 cfg to build.rs

@MabezDev
Embassy init updates:
23f1ed0 
- Rename timg feature to timg0 to better refect which TG is being used
- Use the time_driver::TimerType in the signature of init to fix #268
- Update examples
- Fix CI features
- Add timg0 cfg to build.rs
@MabezDev MabezDev marked this pull request as ready for review December 8, 2022 14:11
bjoernQ
bjoernQ approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jessebraham
jessebraham approved these changes Dec 8, 2022
View reviewed changes
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jessebraham jessebraham merged commit 0000d46 into main Dec 8, 2022
@MabezDev MabezDev deleted the embassy/td-init-fix branch December 9, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernQ bjoernQ bjoernQ approved these changes

@jessebraham jessebraham jessebraham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

embassy time driver appears to be unsound
3 participants
@MabezDev @jessebraham @bjoernQ