-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create newtypes for all PAC peripherals, mark unstable peripheral singletons #2957
Conversation
75d3958
to
4a9ea47
Compare
This is a consequence of using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@@ -274,6 +274,7 @@ pub mod dma { | |||
} | |||
|
|||
/// A DMA capable AES instance. | |||
#[instability::unstable] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is marking the the top level module unstable not enough? Just for future me's understanding :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something in the traits ends up not compiling because of some public reexport somewhere, it's a bit of a mess that I'm trying to untangle. (Specifically, without these we have Private type in public interface errors)
Trying to break up #2956 into more manageable pieces :)
This change wraps all PAC types we use as peripherals in a newtype. This is a step toward removing the
Deref
implementation, and we'll no longer have to guess which of theperipheral::STUFF
is a PAC peripheral, and which one is our newtype.The PR also lets us hide some of the useless peripheral singletons - so far, only behind the unstable flag, but we should go one step further and introduce a
private
category for things likeFE
, orNRX
.