Implement embedded_hal_async::delay::DelayUs trait for SYSTIMER alarms
#812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
bjoernQ
reviewed
Sep 22, 2023
| pub fn set_period(&self, period: fugit::HertzU32) { | ||
| let time_period: MicrosDurationU32 = period.into_duration(); | ||
| let us = time_period.ticks(); | ||
| pub fn set_period(&self, period: MicrosDurationU32) { |
There was a problem hiding this comment.
I guess a duration better matches a time period but just want to make sure we all agree since it's a change in public API
There was a problem hiding this comment.
I would recommend changing the name otherwise, it was misleading before IMO. Don't really care which units we ultimately accept as arguments but for the given function name this made more sense to me.
bjoernQ
approved these changes
Sep 22, 2023
bugadani
reviewed
Sep 23, 2023
MabezDev
approved these changes
Sep 25, 2023
|
(Sorry, forgot the search in VS Code has weird behavior in workspaces, will fix) |
jessebraham
force-pushed
the
feature/async-delay
branch
from
71639b4 to
58432d7
Compare
bugadani
reviewed
Sep 26, 2023
| } | ||
|
|
||
| #[interrupt] | ||
| fn SYSTIMER_TARGET0() { |
There was a problem hiding this comment.
@jessebraham This change broke embassy. The interrupt handlers may already be defined by
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completes one task of #752. Changes should be pretty straight-forward, though I have renamed some things for consistency as well.
The async functionality requires the
Alarmto first be put inPeriodicmode, but I don't think is an issue.There isn't really an example of this, as I don't think it really makes sense, but I did test this locally by modifying the
embassy_hello_worldexample as needed.