-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest PACs and resolve the (numerous) resulting errors #984
Conversation
The @AnthonyGrondin if you're able to find some time to review the changes to these two drivers and the alignment helper that would be much appreciated, I think you probably understand these parts much better than I do 😅. No pressure, of course. |
I have self-reviewed this, and other than the aforementioned drivers I think everything should be okay. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my point of view
Will test on other chips as well. EDIT: ESP32 and ESP32-S3 both fail in the same way, other crypto examples seem fine. Really strange issue. |
Fixed the issue, based on my limited testing all crypto peripherals seem to be working now. |
Oh yeah, I had forgot. Since the alignment changed, we have to update the bit shifting. I'll test those new changes with my implementation of |
Considering that this PR is basically blocking all others, what would you think about merging as is and hammering out the remaining issues later? |
I've done a few testing with my current bignum impl. Self-tests and sync_server works, but both will soft-lock if I try to run them in release mode. I cannot tell if it's my implementation or a bug in the driver, as it's doing this when also using the current origin before the changes in the PACS. |
Okay, thanks for the updates. If the behaviour is the same prior to these changes then I will just go ahead and merge this to get other PRs unblocked. At least we're not in any worse shape than we were before, we can address these issues in a subsequent PR. |
Well, this ended up being a monumental task 😅 Hope I never need to do anything like this again.
Apologies for the massive PR but unfortunately it's not really possible to do this incrementally. I'm not sure how well this can reasonably be reviewed, but things that should be focused on (IMO) include:
main
. I believe I have not broken anything but some additional confirmation will be neededI will try to do another review of my changes (though I'm a little tired of looking at all this 😂) and do some more testing on hardware.
No user-facing changes here, so I have not updated
CHANGELOG.md
.