-
Notifications
You must be signed in to change notification settings - Fork 24
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Download both the release artifacts in extended mode for LLVM >= 17
The Espressif-provided LLVM toolchain no longer has the libs-only tarball as a strict subset of the full tarball. Instead the "full" tarball now contains a clang with libclang built in. To work around this we now need to get _both_ tarballs if we're in extended LLVM mode. Cf. espressif/llvm-project#99 Signed-off-by: Johannes Löthberg <johannes.loethberg@elokon.com>
- Loading branch information
1 parent
84081c2
commit 9c0234d
Showing
2 changed files
with
42 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9c0234d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SergioGasquez Any chance for a release with this inside?
9c0234d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! I have plans on releasing it next week, is there any need for it earlier?
9c0234d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, it's currently broken and it's breaking previous behavior. Personally, I'd appreciate a hotfix release.
9c0234d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand, but is there any reason not to use
cargo install espup --git https://github.com/esp-rs/espup
in the meantime? If there's a specific reason to avoid this, I can proceed with a release now. We're aiming to hold off until next week to align with the Xtensa Rust release, and to avoid potentially needing two releases if any additional features or bug fixes arise.9c0234d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm talking from the perspective of someone maintaining this in Arch. I guess I could just backport it, though.
9c0234d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah! That completely makes sense! espup@0.12.1 was just released! Sorry for the delay, I had a few days of vacation last week.
9c0234d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok nice, thanks.