Skip to content

Commit

Permalink
Remove 400b stack allocation from AdvWeb example
Browse files Browse the repository at this point in the history
The AdvancedWebServer.ino example allocated a 400 byte char array on the
stack which, in the case of the example, will work but in general is a
dangerous thing to show new users to try.

Instead, use a StreamString to generate the string on the heap.
  • Loading branch information
earlephilhower committed Jan 7, 2023
1 parent a76852a commit 1f3f8d9
Showing 1 changed file with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
#include <WiFiClient.h>
#include <ESP8266WebServer.h>
#include <ESP8266mDNS.h>
#include <StreamString.h>

#ifndef STASSID
#define STASSID "your-ssid"
Expand All @@ -47,14 +48,14 @@ const int led = 13;

void handleRoot() {
digitalWrite(led, 1);
char temp[400];
int sec = millis() / 1000;
int min = sec / 60;
int hr = min / 60;

snprintf(temp, 400,

"<html>\
StreamString temp;
temp.reserve(500); // Preallocate a large chunk to avoid memory fragmentation
temp.printf("\
<html>\
<head>\
<meta http-equiv='refresh' content='5'/>\
<title>ESP8266 Demo</title>\
Expand All @@ -68,9 +69,8 @@ void handleRoot() {
<img src=\"/test.svg\" />\
</body>\
</html>",

hr, min % 60, sec % 60);
server.send(200, "text/html", temp);
server.send(200, "text/html", temp.c_str());
digitalWrite(led, 0);
}

Expand Down

0 comments on commit 1f3f8d9

Please sign in to comment.