Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]Item menu for Puya chips #6359

Closed
luc-github opened this issue Jul 30, 2019 · 8 comments · Fixed by #6362
Closed

[FR]Item menu for Puya chips #6359

luc-github opened this issue Jul 30, 2019 · 8 comments · Fixed by #6362

Comments

@luc-github
Copy link
Contributor

luc-github commented Jul 30, 2019

Hi,
I got several requests from people not able to enable Puya patch.
If for common developer this action looks trivial :

Create platform.local.txt in esp8266 core directory and add these lines:

compiler.c.extra_flags= -DPUYA_SUPPORT=1
compiler.cpp.extra_flags={compiler.c.extra_flags}
like explained here: https://github.com/esp8266/Arduino/pull/5504#issuecomment-490111960

but for many people, new in arduino development, they do not understand what actually need to be done, so I got several people who ,even after reading these lines, are not able to get their esp8266 with puya chip working with SPIFFS (and may be also littleFS in next release ?).
Not mentioning people using google translator to understand it...

I know current menu is already heavy, but I think it would be a great benefit for new people to have an item menu to enable/not disable the puya patch, additionnaly there was a lot of work done on this patch, so make it visible is also good IMHO.

What do you think ?

@d-a-v
Copy link
Collaborator

d-a-v commented Jul 30, 2019

I agree with enabling PUYA support by default, even without menu to disable it.
Today we need -DPUYA_SUPPORT=1.
I propose to change this to use instead -DPUYA_SUPPORT=0 to disable it.
It also would remain compatible with those who already have -DPUYA_SUPPORT=1 in their environment.

@TD-er
Copy link
Contributor

TD-er commented Jul 30, 2019

Just keep in mind the remark made here by @igrr : #5504 (review)
If that's not an issue, then I think having it enabled by default would save a lot of frustration.

@luc-github
Copy link
Contributor Author

Thank you ^_^

@adapso
Copy link

adapso commented Dec 20, 2019

I'm on this list of beginners.
What core version is the platform.local.txt file to be created in?
His content is only: compiler.c.extra_flags= -DPUYA_SUPPORT=1
compiler.cpp.extra_flags={compiler.c.extra_flags}
like explained here: #5504 (comment)

@devyte
Copy link
Collaborator

devyte commented Dec 20, 2019

@adapso you shouldn't need to do anything, puya support is enabled by default in our core, and has been for several releases now.

@adapso
Copy link

adapso commented Dec 20, 2019

Unfortunately with me it does not work. I have about 30 PUYA units that I can't use. I currently use Esp8266 arduino IDE 1.8 and core 2.4.0

@d-a-v
Copy link
Collaborator

d-a-v commented Dec 20, 2019

PUYA chips are not supported in release 2.4.0.
They are supported by default starting from 2.6.0.

@adapso
Copy link

adapso commented Feb 27, 2020

I have the following problem, I was waiting for a correction for the PUYA problem for over a year. This week after resuming the project I upgraded to the core version 2.6.3 of ESP8266, for my happiness ESP returned to save the information correctly in the flash using SPIFFS, but to my sadness this version caused some problem with the ESP connection, I fired a notification using the Pushover API. In core version 2.4.2 the shooting works very well, but in version 2.6.3 it is not working. Can anyone help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants