Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable PUYA flash chips support by default #6362

Merged
merged 1 commit into from
Jul 31, 2019
Merged

enable PUYA flash chips support by default #6362

merged 1 commit into from
Jul 31, 2019

Conversation

d-a-v
Copy link
Collaborator

@d-a-v d-a-v commented Jul 30, 2019 •
edited
Loading

It can be disabled with -DPUYA_SUPPORT=0.

closes #6359

devyte
devyte approved these changes Jul 31, 2019
View reviewed changes
Copy link
Collaborator

@devyte devyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, let's take this leap.
Per current implementation, impact for non-PUYA users is minimal, so enabling for all should be ok.
Of note, for non-PUYA users the impact is a slight bin size increase.

@devyte devyte merged commit d6973cd into esp8266:master Jul 31, 2019
@d-a-v d-a-v deleted the puyaforever branch July 31, 2019 20:47
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devyte devyte devyte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR]Item menu for Puya chips
2 participants
@d-a-v @devyte