Allow to disable DHCP gateway offer when set up of AP. #4421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-a-v
approved these changes
Feb 23, 2018
|
While this really does not seem smart on the of the DHCP client, mine (dhclient on Ubuntu 16.04) happily adds a default route via 0.0.0.0 when advertised. That's the reason for this patch. |
|
Ping! Not to add noise, but I think this has simply been forgotten. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the ESP8266 in AP mode, it will advertise a default gateway via DHCP, even if it cannot route traffic anywhere. This patch simply disables the gateway offer, when the gateway is set to 0.0.0.0.
See also: