Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i2s can send now buffers #5349

Merged
merged 13 commits into from
Nov 24, 2018
Merged

i2s can send now buffers #5349

merged 13 commits into from
Nov 24, 2018

Conversation

aguaviva
Copy link
Contributor

This is more efficient than sending samples individually. Actually my https://github.com/aguaviva/ESP8266-phone wont work fast enough without this call I added.

@earlephilhower earlephilhower added this to the 2.6.0 milestone Nov 19, 2018
earlephilhower
earlephilhower requested changes Nov 19, 2018
View reviewed changes
Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start! If you can make it generally applicable as noted in the review comments, it'll be very handy and reduce CPU significantly!

cores/esp8266/core_esp8266_i2s.c Outdated Show resolved Hide resolved
cores/esp8266/core_esp8266_i2s.c Outdated Show resolved Hide resolved
@aguaviva
Copy link
Contributor Author

aguaviva commented Nov 21, 2018 •
edited
Loading

The code looks good but to be honest when I use the buffer function I get slightly distorted audio. I used a logic analyzer to sniff the i2c bus but all seems to be fine (the timings and the test data are correct).

@aguaviva
Copy link
Contributor Author

I made a small optimization. As I said the code is correct, the sniffing of the I2C bus looks good and it looks like the distortion is coming from my I2C HW (pcm5100) who is causing it, I can't even get a proper sine wave (Checked with my oscilloscope). Please lets move this to the next step :)

@earlephilhower
Copy link
Collaborator

Looks good, should be very useful. Thanks!

@earlephilhower earlephilhower modified the milestones: 2.6.0, 2.5.0 Nov 23, 2018
@aguaviva
Copy link
Contributor Author

BTW this was my first pull request ever so thanks for your patience :) Silly question, who what am I supposed to do now? Close the pull request?

@devyte
Copy link
Collaborator

devyte commented Nov 23, 2018

Nope, now it gets merged, assuming no further comments :)

devyte
devyte requested changes Nov 23, 2018
View reviewed changes
Copy link
Collaborator

@devyte devyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only signed => unsigned comments.

cores/esp8266/core_esp8266_i2s.c Outdated Show resolved Hide resolved
cores/esp8266/core_esp8266_i2s.c Outdated Show resolved Hide resolved
cores/esp8266/core_esp8266_i2s.c Outdated Show resolved Hide resolved
cores/esp8266/core_esp8266_i2s.c Outdated Show resolved Hide resolved
cores/esp8266/core_esp8266_i2s.c Outdated Show resolved Hide resolved
@devyte devyte merged commit cf21dfd into esp8266:master Nov 24, 2018
@devyte
Copy link
Collaborator

devyte commented Nov 24, 2018

Congrats on your first PR! You're done now. This is now available in master branch (aka latest git) and will be released in the next core version.

@aguaviva
Copy link
Contributor Author

wohoo! :D

@earlephilhower earlephilhower mentioned this pull request Nov 28, 2018
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@earlephilhower earlephilhower earlephilhower approved these changes

@devyte devyte devyte approved these changes

Assignees

@earlephilhower earlephilhower

Labels
component: libraries staged-for-release type: enhancement
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@aguaviva @earlephilhower @devyte