Implement for ssid a similar approach as for passphrase #5411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
earlephilhower
approved these changes
Dec 3, 2018
| @@ -119,10 +119,12 @@ wl_status_t ESP8266WiFiSTAClass::begin(const char* ssid, const char *passphrase, | |||
| } | |||
|
|
|||
| struct station_config conf; | |||
| strcpy(reinterpret_cast<char*>(conf.ssid), ssid); | |||
| if(strlen(ssid) == 32) | |||
There was a problem hiding this comment.
strncpy(reinterpret_cast<char*>(conf.ssid), ssid, 32); will do the same w/o any if required.
From the man page, this is one of the intended uses:
One valid (and intended) use of strncpy() is to copy a C string to a fixed-length buffer while ensuring both that the buffer is not overflowed and that unused bytes in the target buffer are zeroed out (perhaps to prevent information leaks if the buffer is to be written to media or transmitted to another process via an interprocess communication technique).
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2200 (in theory)
Fixes #4911
Replaces #4691
This is not tested. The PR doesn't affect the pre-PR case (ssid up to 31chars). If the implementation doesn't work, and assuming no bug in the approach (same code as for passphrase with 64 bytes), then there is something broken in the SDK, and likely nothing can be done here.