Fix boards-manager install issues on Linux and Windows #5898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes esp8266#5881 The path to python.exe on Windows needs to change depending on whether it is installed via the boards manager or GIT (similar to the compiler paths). Adjust accordingly.
An empty "python" directory will be created by the boards-manager installer. Required because all archs need all tools defined.
|
@devyte , @d-a-v this change introduces a "tools/python/python" symlink to "/usr/bin/python" on UNIX-like OSes. The alternative is to make that symlink a simple wrapper (either a bash file "python $*" or even a python file that calls itself with the passed-in args. This is required because we need a "python" tool in the package.JSON file. Its existence causes the Arduino boards.txt to override the {runtime.tools.python.path} var, and that can't be overridden by a boards.txt value (as it is done in GIT builds). So you need something called "python" in that python tool.tar.gz file, and that's what the IDE is going to call. The IDE basically forces it when installed via boards-manager. |
Fixes a typo in the python path for Windows for upload.
earlephilhower
force-pushed
the
pythonspot
branch
from
37c7e81
to
d851ba6
Compare
Fixes a typo in the python path for Windows for upload.
earlephilhower
force-pushed
the
pythonspot
branch
from
d851ba6
to
650c8c7
Compare
d-a-v
approved these changes
Apr 10, 2019
devyte
approved these changes
Apr 10, 2019
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5881
The path to python.exe on Windows needs to change depending on whether
it is installed via the boards manager or GIT (similar to the compiler
paths). Adjust accordingly.
An empty "python" directory will be created by the boards-manager
installer in Linux to avoid "tool not available" errors, and it will contain a symlink
to the real system Python executable.
Tested under Linux GIT, Linux board-manager, Windows git, and
Windows board-manager.