Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a dump of received FP and CERT when in debug mode #6300

Merged
merged 6 commits into from
Jul 14, 2019
Merged

Add a dump of received FP and CERT when in debug mode #6300

merged 6 commits into from
Jul 14, 2019

Conversation

earlephilhower
Copy link
Collaborator

To simplify BearSSL debugging, print the received FP (when it doesn't
match the expected) and the binary certificate (always), when in debug
mode.

@earlephilhower
Add a dump of received FP and CERT when in debug mode
ff6e94b 
To simplify BearSSL debugging, print the received FP (when it doesn't
match the expected) and the binary certificate (always), when in debug
mode.
@earlephilhower
Update to -n- versions of string fcns, resize array
9115682 
Per review, clean up and comment.
@earlephilhower
Copy link
Collaborator Author

Ah, crap. strncat is one of those funny functions that I remember MSFT warning us about. The n there is the max # of elements of the src, not the total length. Let me update PR with strlcat which does what a sane person would want it to do...

@earlephilhower earlephilhower merged commit c18b402 into esp8266:master Jul 14, 2019
@earlephilhower earlephilhower deleted the dumpcertfp branch July 14, 2019 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devyte devyte devyte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@earlephilhower @devyte