-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental: add new WiFi (pseudo) modes: WIFI_SHUTDOWN & WIFI_RESUME #6356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
restore WiFi.onWiFiModeChange() add crc32() in core
d-a-v
changed the title
add new WiFi modes: WIFI_SHUTDOWN & WIFI_RESUME with example
add new WiFi (pseudo) modes: WIFI_SHUTDOWN & WIFI_RESUME with example
Jul 29, 2019
5 tasks
d-a-v
changed the title
add new WiFi (pseudo) modes: WIFI_SHUTDOWN & WIFI_RESUME with example
add new WiFi (pseudo) modes: WIFI_SHUTDOWN & WIFI_RESUME
Jul 29, 2019
TD-er
reviewed
Jul 29, 2019
TD-er
reviewed
Jul 29, 2019
moving it where it was
6 tasks
d-a-v
changed the title
add new WiFi (pseudo) modes: WIFI_SHUTDOWN & WIFI_RESUME
Experimental: add new WiFi (pseudo) modes: WIFI_SHUTDOWN & WIFI_RESUME
Aug 30, 2019
devyte
requested changes
Sep 2, 2019
devyte
approved these changes
Sep 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
edit: This is an experimental addition to the API
Adds new WiFi (pseudo) modes: WIFI_SHUTDOWN & WIFI_RESUME,
also:
references:
#6346
#6266
#6057 #5527
This is an attempt to put right into the core all the necessary code to wifi-sleep and deep-sleep so there is only one place to debug for everybody.
I am personally not able to reproduce all the WDT issues so even after hypothetical merge, we will need to bring fixes found by all the community, like #6266 (comment) and #6172 (comment) (only citing them).
This PR does not change legacy behavior when using the regular API (well.. not supposed to :]).