Inline ESP::getCycleCount() to make it safe to call from ISRs #6477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dok-net
force-pushed
the
isr_safe_cyclecount
branch
from
b531158 to
95298e4
Compare
d-a-v
approved these changes
Sep 2, 2019
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Someone found out that on the ESP32, ESP::getCycleCount() is not ISR safe.
While the fix, inlining the machine code, is taken from ESP8266, on this platform I suggest additionally adding
__attribute__((always_inline))to the respective functions to force the GCC to inline, no matter what compiler options are used by the build process.
This is a port of the fixing PR espressif/arduino-esp32#3165.