Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put longer string literals into PROGMEM #6588

Merged
merged 2 commits into from
Oct 4, 2019
Merged

Put longer string literals into PROGMEM #6588

merged 2 commits into from
Oct 4, 2019

Conversation

dirkmueller
Copy link
Contributor

No description provided.

earlephilhower
earlephilhower approved these changes Oct 3, 2019
View reviewed changes
Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dirkmueller dirkmueller force-pushed the EqualsCase_cleanup branch 2 times, most recently from d3d5096 to c965fbe Compare October 3, 2019 21:26
@dirkmueller dirkmueller force-pushed the EqualsCase_cleanup branch 4 times, most recently from 7f22ac5 to 3be6d88 Compare October 3, 2019 22:58
@dirkmueller
Use Flash Strings for Debug output
8c3268f 
This is hopefully very infrequently used, so it shouldn't
be in main memory.
@devyte devyte merged commit 3890e1a into esp8266:master Oct 4, 2019
@devyte devyte added this to the 2.6.0 milestone Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@earlephilhower earlephilhower earlephilhower approved these changes

@devyte devyte devyte approved these changes

Assignees
No one assigned
Labels
component: libraries type: enhancement
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dirkmueller @earlephilhower @devyte