Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand NTP-TZ-DST example to list SNTP servers #6611

Merged

Conversation

davefiddes
Copy link
Contributor

This change expands the NTP-TZ-DST example to list the active
SNTP servers. It lists the IP address server name (if used) and
reachability in ntpq style octal format.

Tests:

  • Build against all LwIP stack configurations and correct
    operation with a single SNTP server
  • Vary connectivity to an SNTP server and check reachability
    updates
  • Configure 3 SNTP servers by name
  • With a patched LwIP stack that supports simultaneous DHCP
    and DHCPv6 SNTP servers check that all server details are
    listed and update correctly during operation

This change expands the NTP-TZ-DST example to list the active
SNTP servers. It lists the IP address server name (if used) and
reachability in ntpq style octal format.

Tests:
 - Build against all LwIP stack configurations and correct
   operation with a single SNTP server
 - Vary connectivity to an SNTP server and check reachability
   updates
 - Configure 3 SNTP servers by name
 - With a patched LwIP stack that supports simultaneous DHCP
   and DHCPv6 SNTP servers check that all server details are
   listed and update correctly during operation
Copy link
Collaborator

@d-a-v d-a-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your sntp fix in lwip2 is not yet updated in esp8266/arduino

@davefiddes
Copy link
Contributor Author

Thanks David. This change works fine with or without my other fixes.

Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@earlephilhower earlephilhower merged commit d3debb6 into esp8266:master Oct 8, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants