MDNS: fix legacy unicast responses #6613
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to resolve mdns hostname using lwip built-in resolver (
WiFi.hostByName("something.local")
), LeaMDNS responder does not construct a response that lwip expects. While it does preserve the request ID here:Arduino/libraries/ESP8266mDNS/src/LEAmDNS_Control.cpp
Lines 248 to 250 in 48ca7cf
This ID is never set when preparing the message:
(debugging message could be improved though)