Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

host build: optimistic_yield() wrongly delays() instead of avoiding excessive yields #6802

Merged
merged 3 commits into from
Jan 28, 2020
Merged

host build: optimistic_yield() wrongly delays() instead of avoiding excessive yields #6802

merged 3 commits into from
Jan 28, 2020

Conversation

dok-net
Copy link
Contributor

@dok-net dok-net commented Nov 18, 2019

On host, can work just like plain yield() there - do nothing at all.

@dok-net dok-net changed the title optimistic_yield() now delays() instead of avoiding extraneous yields host build: optimistic_yield() now delays() instead of avoiding extraneous yields Nov 18, 2019
@dok-net dok-net changed the title host build: optimistic_yield() now delays() instead of avoiding extraneous yields host build: optimistic_yield() wrongly delays() instead of avoiding extraneous yields Nov 18, 2019
devyte
devyte approved these changes Nov 18, 2019
View reviewed changes
Copy link
Collaborator

@devyte devyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optimistic_yield does not delay, but rather checks if it should yield or not, so removing the usleep looks correct to me.

@devyte devyte requested a review from d-a-v November 18, 2019 22:13
@dok-net
Copy link
Contributor Author

dok-net commented Nov 19, 2019

PR is OK, CI once more has network issues?!

@dok-net dok-net force-pushed the host_optimistic_yield branch 2 times, most recently from a2efe4f to 37c9682 Compare November 21, 2019 21:09
@dok-net dok-net changed the title host build: optimistic_yield() wrongly delays() instead of avoiding extraneous yields host build: optimistic_yield() wrongly delays() instead of avoiding excessive yields Dec 4, 2019
@dok-net dok-net force-pushed the host_optimistic_yield branch 2 times, most recently from 06b0723 to bdd943e Compare December 11, 2019 13:44
@earlephilhower earlephilhower merged commit bb696dd into esp8266:master Jan 28, 2020
@dok-net dok-net deleted the host_optimistic_yield branch January 28, 2020 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-a-v d-a-v d-a-v approved these changes

@devyte devyte devyte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dok-net @d-a-v @devyte @earlephilhower