Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing boards in package_esp8266com_index.template.json #7018

Merged
merged 1 commit into from
Jan 17, 2020

Conversation

mhightower83
Copy link
Contributor

Updated packagegen to use newfilestr instead of filestr when writing the JSON file.
Three missing boards are now in package/package_esp8266com_index.template.json.

@d-a-v please check this. I am not sure where this file gets used or how to
test this change. Before making the change, I was seeing a different result
between --package and --packagegen.

…file.

Three missing boards are now in package/package_esp8266com_index.template.json.
@d-a-v please check this. I am not sure where this file gets used or how to
test this change. Before making the change, I was seeing a different result
between --package and --packagegen.
Copy link
Collaborator

@d-a-v d-a-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks fixing this !

@d-a-v d-a-v merged commit b930c4c into esp8266:master Jan 17, 2020
@mhightower83 mhightower83 deleted the pr-boards.txt-missing-boards branch January 17, 2020 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants