Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated stack offsets for postmortem stack dump. #7066

Merged
merged 1 commit into from
Feb 8, 2020
Merged

Updated stack offsets for postmortem stack dump. #7066

merged 1 commit into from
Feb 8, 2020

Conversation

mhightower83
Copy link
Contributor

Changed ets_putc to ets_uart_putc1 to better newline handling.

@mhightower83
Updated stack offsets for postmortem stack dump.
f45da1c 
Changed ets_putc to ets_uart_putc1 to better newline handling.
earlephilhower
earlephilhower approved these changes Feb 8, 2020
View reviewed changes
Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've restarted the build since the failure looked like transient network issues.

@earlephilhower earlephilhower merged commit 50a491b into esp8266:master Feb 8, 2020
@mhightower83 mhightower83 deleted the pr-postmortem-offset-update branch January 13, 2021 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@earlephilhower earlephilhower earlephilhower approved these changes

@d-a-v d-a-v Awaiting requested review from d-a-v

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhightower83 @earlephilhower