Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring SPIFFS up to latest version #7276

Merged
merged 3 commits into from
May 19, 2020

Conversation

earlephilhower
Copy link
Collaborator

Manually merged the PATCH files from upstream up until Jan 26, 2020.

Looks to only fix a single bug related to reading past the end of a file
in certain cases. Other new features (secure erase) are included to
make it easier to merge any future releases, but are not enabled in the
core.

Merges included:

20fc6df0ab2bee391961b5f823a327887abc96b4
da1cf494796d68bb5c02ba70cf78a904db08a170
13935985cdde6d6b4ec77f2685264242ee55e7ac
ec68ba8208d7550860e4e78299d58a529b88bf85
f59d958e0b2f169b549e5cdc293a70bc6873cd45
f7d3e9f2b207958dfc2c01cf3fc42f98a4b9b239
554b59c147d96223ccce18374989f191f7222b45
07e013056dd976d12ae36db5c54a275e1497f6c8
d0d44c4908efff7a443ed9b1174d9173fb784a72
3cb24dbfd32a396dca46a7ca56a8e75bdcb97078
8172b40813ff36aa0df4c88a6e9c76e5300d7e32

Manually merged the PATCH files from upstream up until Jan 26, 2020.

Looks to only fix a single bug related to reading past the end of a file
in certain cases.  Other new features (secure erase) are included to
make it easier to merge any future releases, but are not enabled in the
core.

Merges included:
20fc6df0ab2bee391961b5f823a327887abc96b4
da1cf494796d68bb5c02ba70cf78a904db08a170
13935985cdde6d6b4ec77f2685264242ee55e7ac
ec68ba8208d7550860e4e78299d58a529b88bf85
f59d958e0b2f169b549e5cdc293a70bc6873cd45
f7d3e9f2b207958dfc2c01cf3fc42f98a4b9b239
554b59c147d96223ccce18374989f191f7222b45
07e013056dd976d12ae36db5c54a275e1497f6c8
d0d44c4908efff7a443ed9b1174d9173fb784a72
3cb24dbfd32a396dca46a7ca56a8e75bdcb97078
8172b40813ff36aa0df4c88a6e9c76e5300d7e32
@earlephilhower
Copy link
Collaborator Author

@TD-er, you seem to be a big SPIFFS user. Can you give this a try? I really don't think it should change any behavior, but would love independent verification beyond our host tests.

@devyte
Copy link
Collaborator

devyte commented May 16, 2020

@TD-er ping

@TD-er
Copy link
Contributor

TD-er commented May 16, 2020

Sorry, it slipped my mind to make a test build for it.
Just by looking at the code I don't see any obvious issues why it shouldn't work, but I will try to make a test build. (should be less problematic these days with the platform_packages introduced in PlatformIO)

@TD-er
Copy link
Contributor

TD-er commented May 17, 2020

I've made a test build with it and have not seen any issues so far.

It was only tested by me, so still no heavy testing, but the normal things in ESPEasy run just fine with it.

@earlephilhower earlephilhower added this to the 2.7.2 milestone May 18, 2020
@earlephilhower earlephilhower merged commit 5762712 into esp8266:master May 19, 2020
@earlephilhower earlephilhower deleted the spiffsupdt branch May 19, 2020 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants