-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I2C pin assignment fix #7416
I2C pin assignment fix #7416
Conversation
There was a typo in I2C pin assignment, SCL was set to GPIO #4 instead of GPIO #14, The schematic can be seen here: https://github.com/OLIMEX/ESP8266/blob/master/HARDWARE/MOD-WIFI-ESP8266-DEV/MOD-WiFi-ESP8266-DEV%20revision%20B1/MOD-WiFi-ESP8266-DEV_Rev_B1.pdf
esp8266 Arduino Wire library does software I2C. it doesn't matter what pair of pins is used. for most variants io 4 and io 5 are the defaults |
@JAndrassy As I understand it, this is the definition meant for a specific board. |
and what? defaults can't change after 2 years. and pin 14 is used for SPI so it would be not a good default |
@JAndrassy Is this some joke I don't get or the heat wave got to you? variants/modwifi is made specifically for Olimex ESP8266-MOD-WIFI-DEV by a contributor and he made a typo for the I2C pins that are specifically routed to a specific connector available only in Olimex ESP8266-MOD-WIFI-DEV, this doesn't affect other boards. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Relax, guys, we're all just trying to do the right thing here and not break the repo.
While I don't see it explicitly labeled as-such, if you do look at the PDF schematic you can see the 2K pullup on GPIO14 which does make sense for I2C, @JAndrassy . It's also only for the modwifi variant so this won't affect any board not using this setup.
So, seeing as I can see @DanKoloff is responsible for the Olimex repos and the change meshes with the schematic, LGTM.
We will try to assign somebody to fix the variants for all Olimex ESP8266 boards, it seems we didn't commit properly here. Just want to ask if it is usually ok to change folder names, this modwifi is kind of vague and also misleading but alas it wasn't our doing. |
Pull requests to improve this repository are always welcome. |
I don't see how I could I know that @DanKoloff represents Olimex. |
There was a typo in I2C pin assignment, SCL was set to GPIO #4 instead of GPIO #14, The schematic can be seen here: https://github.com/OLIMEX/ESP8266/blob/master/HARDWARE/MOD-WIFI-ESP8266-DEV/MOD-WiFi-ESP8266-DEV%20revision%20B1/MOD-WiFi-ESP8266-DEV_Rev_B1.pdf