-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed PUYA flash write buffer alignment #7491
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks! The rounding up to x4 is a little odd but I think it works fine.
FTR, this over-reads |
Thanks for the observation @yumkam , must have missed this somehow. Another pull request is on the way. |
As for the overreading I have not seen a flash that is not 4-byte aligned. All the functions for spi_flash ops have |
This merge fixes flash writing on PUYA flashes when write size is not a multiple of 4.
This bug prevents updating via Arduino OTA when using gzipped image.