-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed bug in parsing POST file uploads #7543
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nothing jumps at me after carefully reading.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strangely enough I was unable to reproduce your failure with master
using the same PEM as you did, but I do see the issue you found in the existing code. Things have to align poorly in the HTTP stream to hit it, I guess.
Thx for the PR!
This PR fixes #7542. I rewrote the section of the Web Server library which handles files being uploaded via POST requests.