Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup #7554: Inline, fewer LOC, remove redundant definition in cpp. #7557

Merged
merged 3 commits into from
Sep 1, 2020

Conversation

dok-net
Copy link
Contributor

@dok-net dok-net commented Aug 28, 2020

No description provided.

@d-a-v d-a-v requested a review from devyte August 28, 2020 16:55
@d-a-v
Copy link
Collaborator

d-a-v commented Aug 28, 2020

Title should be

Fixup #7554: ...

@dok-net dok-net changed the title Fixup #7556: Inline, fewer LOC, remove redundant definition in cpp. Fixup #7554: Inline, fewer LOC, remove redundant definition in cpp. Aug 28, 2020
@dok-net
Copy link
Contributor Author

dok-net commented Aug 28, 2020

@d-a-v totally right, sorry, switched lines on copy&paste.

cores/esp8266/Esp.h Outdated Show resolved Hide resolved
@dirkmueller
Copy link
Contributor

there are out of band inlines in Esp.h at the end. I don't really care which way, but it would be great to stay consistent..

@devyte devyte merged commit 885851a into esp8266:master Sep 1, 2020
@dok-net dok-net deleted the fixfix branch September 1, 2020 10:15
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants