Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i2s: adds i2s_rxtxdrive_begin(enableRx, enableTx, driveRxClocks, driveTxClocks) #7748

Merged
merged 4 commits into from
Dec 12, 2020

Conversation

d-a-v
Copy link
Collaborator

@d-a-v d-a-v commented Dec 9, 2020

A dac rx/rxDrive/tx/txDrive parameters are added to allow using only i2s in/out data pin without clock pins.
This is necessary for example in no-DAC mode when i2so-bck and i2so-ws are repurposed,
Found when using SDFS because SPI SS GPIO was overlapped.

edit: Related: earlephilhower/ESP8266Audio#344

A dac parameter is added to allow using only i2s-out-data pin.
This is necessary in no-DAC mode when i2so-bck and i2so-ws are repurposed
especially because they overlap with SPI GPIO.
@d-a-v d-a-v changed the title i2s: adds i2s_rxtxdac_begin(rx,tx,dac): i2s: adds i2s_rxtxdac_begin(rx,tx,dac) Dec 9, 2020
Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for fixing this!

cores/esp8266/core_esp8266_i2s.cpp Outdated Show resolved Hide resolved
cores/esp8266/core_esp8266_i2s.cpp Outdated Show resolved Hide resolved
@d-a-v d-a-v changed the title i2s: adds i2s_rxtxdac_begin(rx,tx,dac) i2s_rxtxdrive_begin(enableRx, enableTx, driveRxClocks, driveTxClocks) Dec 11, 2020
@d-a-v d-a-v changed the title i2s_rxtxdrive_begin(enableRx, enableTx, driveRxClocks, driveTxClocks) i2s: adds i2s_rxtxdrive_begin(enableRx, enableTx, driveRxClocks, driveTxClocks) Dec 11, 2020
Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@earlephilhower earlephilhower merged commit 1e016a4 into esp8266:master Dec 12, 2020
davisonja added a commit to davisonja/Arduino that referenced this pull request Dec 28, 2020
…lash

* upstream/master: (72 commits)
  Typo error in ESP8266WiFiGeneric.h (esp8266#7797)
  lwip2: use pvPortXalloc/vPortFree and "-free -fipa-pta" (esp8266#7793)
  Use smarter cache key, cache Arduino IDE (esp8266#7791)
  Update to SdFat 2.0.2, speed SD access (esp8266#7779)
  BREAKING - Upgrade to upstream newlib 4.0.0 release (esp8266#7708)
  mock: +hexdump() from debug.cpp (esp8266#7789)
  more lwIP physical interfaces (esp8266#6680)
  Rationalize File timestamp callback (esp8266#7785)
  Update to LittleFS v2.3 (esp8266#7787)
  WiFiServerSecure: Cache SSL sessions (esp8266#7774)
  platform.txt: instruct GCC to perform more aggressive optimization (esp8266#7770)
  LEAmDNS fixes (esp8266#7786)
  Move uzlib to master branch (esp8266#7782)
  Update to latest uzlib upstream (esp8266#7776)
  EspSoftwareSerial bug fix release 6.10.1: preciseDelay() could delay() for extremely long time, if period duration was exceeded on entry. (esp8266#7771)
  Fixed OOM double count in umm_realloc. (esp8266#7768)
  Added missing check for failure on umm_push_heap calls in Esp.cpp (esp8266#7767)
  Fix: cannot build after esp8266#7060 on Win64 (esp8266#7754)
  Add the missing 'rename' method wrapper in SD library. (esp8266#7766)
  i2s: adds i2s_rxtxdrive_begin(enableRx, enableTx, driveRxClocks, driveTxClocks) (esp8266#7748)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants