Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING - "i2s.h" removed, I2S library added #8108

Merged
merged 2 commits into from
Jun 8, 2021
Merged

BREAKING - "i2s.h" removed, I2S library added #8108

merged 2 commits into from
Jun 8, 2021

Commits on Jun 8, 2021

  1. BREAKING - "i2s.h" removed, I2S library added 

    An "i2S.h" header was presesnt in prior cores, but this conflicts with the
Arduino standard I2S.h header for the I2S class under Windows (because of
case insensitivity).

Initial 3.0.0 release has a redirect "i2s.h" file in the cores directory to
redirect to the "I2S.h" file in the library, but under Windows this resulted
in the IDE not building the I2S library and link errors.

Remove the offending header.  Code will need to mode to including "I2S.h"
instead (which will include both the Arduino class as well as the low-level
definitions).

Fixes esp8266#8107
    @earlephilhower
    earlephilhower committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    6e418c0 View commit details
    Browse the repository at this point in the history

  2. Update examples to use proper I2S.h version

    @earlephilhower
    earlephilhower committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    d94552c View commit details
    Browse the repository at this point in the history