Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change protocol detection so uppercase or lowercase works #8137

Merged
merged 3 commits into from
Jun 17, 2021

Conversation

idolpx
Copy link
Contributor

@idolpx idolpx commented Jun 17, 2021

Sometimes a url is specified in all upper case and HTTPClient rejects it when it would be perfectly fine. This just makes the protocol detection case insensitive so the url is accepted if the protocol is uppercase.

Make protocol detection case insensitive
Make protocol detection case insensitive
Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@earlephilhower earlephilhower merged commit 1a5ef71 into esp8266:master Jun 17, 2021
@earlephilhower earlephilhower added this to the 3.0.1 milestone Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants