Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing menu.UploadTool name definition #8153

Merged
merged 1 commit into from
Jun 21, 2021

Conversation

silvanocerza
Copy link
Contributor

Hello!

We recently merged arduino/arduino-cli#1326 on the Arduino CLI, it introduces an enforcement of the platform specifications for custom board options. Boards that define some custom options without their name defined somewhere else in the boards.txt won't be loaded, the rest will be loaded without issues if they respect the specifications.

A user reported in arduino/arduino-cli#1329 that esp8266:esp8266:espduino is not loaded because of this change, this PR will fix that issue.

That change has not been released but is only available in the nightly, so most users are not affected as of now but will in the next release.

@d-a-v
Copy link
Collaborator

d-a-v commented Jun 21, 2021

You need to update this file then run the script:

./tools/board.txt.py --allgen

and commit the changed files (in this case it should only be boards.txt and tools/boards.txt.py).

Or we can do it for you, as you prefer.

CI did not pass because the same process is applied (which removes your change) and compared.

@silvanocerza silvanocerza force-pushed the fix-boards-txt-menu-definition branch from 8b448cd to 0013271 Compare June 21, 2021 09:01
@silvanocerza
Copy link
Contributor Author

@d-a-v no worries, I fixed it. Didn't notice the boards.txt was generated automatically.

Copy link
Collaborator

@d-a-v d-a-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Didn't notice the boards.txt was generated automatically.

Given the number of boards and tuning options, that was necessary when any change in the tools menu was duplicated and subject to errors.

@d-a-v d-a-v merged commit 78e6328 into esp8266:master Jun 21, 2021
@patoberli
Copy link

Would it be possible to backport this to 2.7.4? It seems this change is required for Arduino IDE 2.x support. For more information see the thread in the Arduino forum: https://forum.arduino.cc/t/ide-2-0-beta-9-not-working-wemos-d1-mini-esp8266/891349/4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants