Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

platformio: use CCFLAGS for -Werror #8175

Merged
merged 1 commit into from
Jun 26, 2021
Merged

Conversation

mcspr
Copy link
Collaborator

@mcspr mcspr commented Jun 25, 2021

Fixup #8165, as it only changed behaviour for .c files

Also adds some comments referencing SCons documentation (literally)

Also adds some comments referencing SCons documentation
Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this and adding comments so it's unlikely to happen again!

@earlephilhower earlephilhower added this to the 3.0.1 milestone Jun 26, 2021
@earlephilhower earlephilhower merged commit 019fab4 into esp8266:master Jun 26, 2021
@mcspr mcspr deleted the patch-1 branch June 26, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants