Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add comments and corrections #8201

Merged

Conversation

mhightower83
Copy link
Contributor

No description provided.

Added conditional build around option 'p' to call stack_thunk_dump_stack
which can only print when debug is enabled.
Copy link
Collaborator

@d-a-v d-a-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the ROM disassembly, it does seem that there is no UART param in ets_install_uart_printf, so LGTM. Thx!

@earlephilhower earlephilhower merged commit a105bdd into esp8266:master Jul 8, 2021
@mhightower83 mhightower83 deleted the pr-comments-and-corrections branch July 9, 2021 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants