-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mmu_get... and mmu_set... #8290
Merged
mcspr
merged 10 commits into
esp8266:master
from
mhightower83:pr-mmu-inline-strict-aliasing
Oct 13, 2021
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
a8aed29
Update mmu_get... and mmu_set... to comply with strict-aliasing rules.
mhightower83 bac14f2
Update mmu_get... and mmu_set... to comply with strict-aliasing rules.
mhightower83 0cc26d6
style
mhightower83 370c1c8
Merge branch 'pr-mmu-inline-strict-aliasing' of github.com:mhightower…
mhightower83 cb859e4
Merge branch 'master' into pr-mmu-inline-strict-aliasing
mhightower83 5df867f
Removed stale comment
mhightower83 45bcfa9
Merge branch 'master' into pr-mmu-inline-strict-aliasing
mhightower83 ebbac7b
Simplified use of aligas
mhightower83 9814f70
Added CORE_MOCK #if. Updated related examples.
mhightower83 bd31242
Merge branch 'master' into pr-mmu-inline-strict-aliasing
mcspr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess make sense with the available definitions, naming would also simplify migration to anything else.
Looking at the RTOS, there is esp8266/eagle_soc.h declaring various IRAM_..., DRAM_..., RTC_... preprocessor tokens and funcs related to ranges. This is out-of-scope here, but I wonder if something like this is warranted for the repo as well (and since even the 3.x NONOS does not have anything of sorts)