Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warnings, errors during host tests in CI #8358

Merged
merged 5 commits into from
Nov 2, 2021

Commits on Oct 31, 2021

  1. Remove warnings, errors during host tests in CI

    Debug strings often included format parameters which did not exactly match
    the passed in format parameters, resulting in warnings in the host test build
    process like
    ````
    /home/runner/work/Arduino/Arduino/libraries/ESP8266WiFi/src/ESP8266WiFiAP.cpp:107:20: warning: format ‘%u’ expects argument of type ‘unsigned int’, but argument 3 has type ‘size_t’ {aka ‘long unsigned int’} [-Wformat=]
      107 |         DEBUG_WIFI("[AP] SSID length %u, too long or missing!\n", ssid_len);
          |                                                                   ~~~~~~~~
          |                                                                   |
          |                                                                   size_t {aka long unsigned int}
    ````
    
    Fix by applying casting or PRxxx macros as appropriate.
    
    Also, fix one debug message which was trying to use a `String` as a `char *`:
    ````
    /home/runner/work/Arduino/Arduino/libraries/ESP8266WiFi/src/ESP8266WiFiMulti.cpp: In member function ‘wl_status_t ESP8266WiFiMulti::connectWiFiMulti(uint32_t)’:
    /home/runner/work/Arduino/Arduino/libraries/ESP8266WiFi/src/ESP8266WiFiMulti.cpp:331:34: warning: format ‘%s’ expects argument of type ‘char*’, but argument 3 has type ‘String’ [-Wformat=]
      331 |                 DEBUG_WIFI_MULTI("[WIFIM] Connecting %s\n", ssid);
    ````
    earlephilhower committed Oct 31, 2021
    Configuration menu
    Copy the full SHA
    7d3c054 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    81c0474 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bf52dbf View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2021

  1. Update per @mcspr comments

    earlephilhower committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    31706c0 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2021

  1. Configuration menu
    Copy the full SHA
    6ce66dd View commit details
    Browse the repository at this point in the history