Fix reuse for different URIs in HTTPClient::begin #8466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-a-v
reviewed
Jan 28, 2022
paulocsanz
changed the title
paulocsanz
changed the title
|
Let's merge this then! I haven't had time to test this deeply and it doesn't seem to fix all problems from the issue, but it's probably useful the way it is. I removed the draft tag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8331
The problem is that
_canReusewas not reset in begin, like inHTTPClient::setURL.Ideally begin should not be called twice if the client hasn't changed, but it may happen, better safe than sorry.