Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly using fs:: namespace in SD & SDFS #8493

Merged
merged 3 commits into from
Feb 23, 2022

Conversation

mcspr
Copy link
Collaborator

@mcspr mcspr commented Feb 20, 2022

Remove using namespace fs; from SDFS.h
Fix everything that depended on it

As noticed in the #8483

Remove `using namespace fs;` from SDFS.h
Fix everything that depended on it
Copy link
Collaborator

@d-a-v d-a-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I got a little lazy in writing the original code, thanks for cleaning it up!

@earlephilhower earlephilhower merged commit ead5f94 into esp8266:master Feb 23, 2022
@mcspr mcspr deleted the no-global-using-fs branch January 7, 2023 00:18
hasenradball pushed a commit to hasenradball/Arduino that referenced this pull request Nov 18, 2024
Remove `using namespace fs;` from SDFS.h
Fix everything that depended on it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants