Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WString: unify numeric conversion and fix assignments #8526

Merged
merged 9 commits into from
Apr 5, 2022
Merged

WString: unify numeric conversion and fix assignments #8526

merged 9 commits into from
Apr 5, 2022

Commits on Mar 30, 2022

  1. WString: unify numeric conversion and fix assignments 

    Restore the pre-3.0.0 behaviour when we could assign numeric values to
the string object. After introducing `operator =(char)`, everything was
converted to `char` instead of the expected 'stringification' of the
number (built-in int, long, unsigned int, unsigned long, long long,
unsigned long long, float and double)
    @mcspr
    mcspr committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    1b56cb2 View commit details
    Browse the repository at this point in the history

  2. cannot assign to uninitialized obj, try to placement-new replace the … 

    …ctor
    @mcspr
    mcspr committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    a192705 View commit details
    Browse the repository at this point in the history

  3. mention the abundance of init()

    @mcspr
    mcspr committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    7e67800 View commit details
    Browse the repository at this point in the history

  4. implement host test

    @mcspr
    mcspr committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    16dff0e View commit details
    Browse the repository at this point in the history

  5. oops

    @mcspr
    mcspr committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    0ca7702 View commit details
    Browse the repository at this point in the history

  6. trying to reduce the instances of where we specify the default base /… 

    … decimalPlaces

branch via if (base == 10) { sprintf(...) } else { ... } instead of separate funcs
reuse the constructor for numeric types where it's possible
    @mcspr
    mcspr committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    4206518 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2022

  1. use pointer from the func, don't default to the &buf[0] 

    nonstd arduino funcs expect this usage pattern
    @mcspr
    mcspr committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    44c8a24 View commit details
    Browse the repository at this point in the history

  2. hint about the length of the buffer 

    also -1 line
    @mcspr
    mcspr committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    d963949 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2022

  1. Merge branch 'master' into arduino-string-can-assign-stuff

    @mcspr
    mcspr committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    9ce12d1 View commit details
    Browse the repository at this point in the history