Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebServer: use String when working with Basic authentication #8548

Merged
merged 4 commits into from
Apr 30, 2022
Merged

WebServer: use String when working with Basic authentication #8548

merged 4 commits into from
Apr 30, 2022

Commits on Apr 21, 2022

  1. WebServer: use String when working with Basic authentication 

    Avoid blowing up user code when `$user:$password` string is longer than
127 bytes. Use String to both manage the memory and handle concatenation.

Also clean-up historical quicks such as
- `authReq = "";` / `authReq = String();`, which will happen anyway
- `(String)...` casts that happen anyway, implicitly
    @mcspr
    mcspr committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    439d146 View commit details
    Browse the repository at this point in the history

  2. fixup! WebServer: use String when working with Basic authentication

    @mcspr
    mcspr committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    f22e37c View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into webserver-basic-auth-overflows

    @mcspr
    mcspr committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    4e0509f View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2022

  1. Merge branch 'master' into webserver-basic-auth-overflows

    @mcspr
    mcspr committed Apr 30, 2022
    Configuration menu
    Copy the full SHA
    ec0e904 View commit details
    Browse the repository at this point in the history