Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actions #8620

Closed
wants to merge 4 commits into from
Closed

Update actions #8620

wants to merge 4 commits into from

Conversation

wrt54g
Copy link

@wrt54g wrt54g commented Jun 27, 2022

I updated the GitHub actions to later versions.

Copy link
Collaborator

@d-a-v d-a-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks,
I see no objection but I still wonder what's hiding behind such changes

@mcspr
Copy link
Collaborator

mcspr commented Jun 27, 2022

Why not v3 for checkout?
Can't we use dependabot to avoid human-dependabot dependency?
https://docs.github.com/en/code-security/dependabot/working-with-dependabot/keeping-your-actions-up-to-date-with-dependabot

@wrt54g
Copy link
Author

wrt54g commented Jun 29, 2022

@d-a-v When will this get merged?
@mcspr This PR updates all actions/checkout to v3 already.

@@ -22,15 +22,15 @@ jobs:
matrix:
chunk: [0, 1, 2, 3, 4, 5, 6, 7]
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3.0.2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ this and cache. why not v3?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcspr Because 3.0.0 is an earlier version than 3.0.2?

Copy link
Collaborator

@mcspr mcspr Jun 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no? :)
action tags like v3 are updated during the action lifetime, they always point to the latest version available
(or, at least this is an expectation)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wrt54g
Copy link
Author

wrt54g commented Jul 1, 2022

Suspended by #8624

@wrt54g wrt54g deleted the update branch July 1, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants