Pointer<->Int casts are not constexpr #8796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcspr
commented
Jan 9, 2023
| @@ -34,7 +33,7 @@ constexpr bool __byteAddressable(const void* addr) | |||
| #include <sys/config.h> | |||
|
|
|||
| // returns true when addr can be used without "pgm_" functions or non32xfer service | |||
| constexpr bool __byteAddressable(const void* addr) | |||
| inline bool __byteAddressable(const void* addr) | |||
| { | |||
| return addr < (const void*)(XCHAL_DATARAM0_VADDR + XCHAL_DATARAM0_SIZE); | |||
There was a problem hiding this comment.
error: constexpr function never produces a constant expression [-Winvalid-constexpr]
note: cast that performs the conversions of a reinterpret_cast is not allowed in a constant expression
(where ^ points at XCHAL expression)
mcspr
changed the title
hasenradball
pushed a commit
to hasenradball/Arduino
that referenced
this pull request
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gcc is more lenient with this, Clang is not