-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESP8266HTTPUpdate: Get available firmware version from update server #8968
Conversation
@d-a-v Would you mind merging this, or do you have any comments / improvements on this? |
I kindly like to ask, if someone can merge this. I use this in several projects of mine and always have to use this branch instead of the HEAD. This should not break anything as it more or less just adds an additional function and some very minor changes (like the before noted enum, the move |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…sp8266#8968) * added getAvailableVersion(), moved _httpClientTimeout and _followRedirects to protected, added enum HTTPUpdateError * auto numbering of HTTPUpdateError enum * added getAvailableVersion(), debug output current current Sketch MD5 * updated advanced updater php script * switch case indention corrected * Revert "added getAvailableVersion(), debug output current current Sketch MD5" This reverts commit 60d2c77. * Revert "auto numbering of HTTPUpdateError enum" This reverts commit 61785b2. * Revert "added getAvailableVersion(), moved _httpClientTimeout and _followRedirects to protected, added enum HTTPUpdateError" This reverts commit cec84ed. * corrected incorrect merge with master
This addresses #8967