-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IDE OTA Upload changes #980
Conversation
mDNS responds with more TXT properties platform change to support OTA functions espota.py added authentication parameter IDE branch: https://github.com/me-no-dev/Arduino-1/tree/esp8266-ota
pull master
I get 100% success with OTA now
pull master
python was keeping the connection open and sending duplicate FINs until the ESP came back online, because the ESP was resetting without giving the network a chance to answer and close
did this fix the error, where the arduino IDE always wanted a password? Elia Bieri |
no. This fixes everything else and adds security |
The new OTA, defines
would that effectively mean i have two objects ota_server & ArduinoOTA in memory? i.e. a waste or resources? |
Today I was actually thinking of reverting this change — I don't think we The pattern of statically allocated instances works well when these On Wed, Nov 11, 2015, 21:54 sticilface notifications@github.com wrote:
|
Ah ok. Good to know. thanks For future reference having two objects, even if one is never used double the memory usage? |
but looked at it differently, you can have only one ArduinoOTA and you allocate it when you include the header |
So even though it's not directly "hardware" related, it still can exist only once. Any other situation will lead to unknown results. You can not have more than one UDP listener on a particular port and even if you could have more, you could not know which one will get the packet and so on. Therefore I strongly believe that in this case a global object should be used (I think I even made it so it does not init twice). |
I agree, only one instance running at a time. My two cents is that i've now got ~ 9 of these in the home, more if u count the ones not running the arduino code... so it means i've got a lot of OTA stuff going on, in that menu. My settings manager allowed me to turn off OTA by deleting a dynamically created OTA object. ( i also see your point looking at the MDNS stuff that there is no destructor , or remove service options, once it is added). This meant I can just have the unstable / projects I'm working on show up. means I'm less likely to go and flash the wrong device. I have to go enable it, then flash it. so +1 for stop method. New lib is ace btw. much better! |
my Arduino IDE branch with IDE Upload included: https://github.com/me-no-dev/Arduino-1/tree/esp8266-ota