Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spell-check package #89

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

DevGuyRash
Copy link

Added a spell-check package that has hundreds of thousands of spell-check replacements. Credit: https://github.com/platers/obsidian-linter/blob/master/src/utils/auto-correct-misspellings.ts

Copy link
Collaborator

@smeech smeech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A very (>3.5MB) large misspelling package.
One benign type: shell cmd: at the bottom. No malicious code.
A handful of minor corrections, and it would be suitable to merge.

Copy link
Collaborator

@smeech smeech May 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last few items and one in the middle (# filename) have propagate_case: misspelled, ironically! 😄
I was interested to see # Fix Double Capitals which is very similar to a snippet of my own which I use daily. Would it be reasonable to put it at the top, or include it as a separate file, so it's easy for Windows users to find and delete or comment out?

@@ -0,0 +1,3 @@
This is a very powerful typo-correction library. It contains hundreds of thousands of typo fixes. The library comes from another developer, so credit where it is due: https://github.com/platers/obsidian-linter/blob/master/src/utils/auto-correct-misspellings.ts

There are also a few custom ones at the bottom. If you are experiencing issues with typing a word and that has two capital letters at the beginning being replaced with lowercase, remove the very last addition.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe highlight the mention of # Fix Double Capitals specifically for Windows users, for whom it won't work.

@@ -0,0 +1,3 @@
This is a very powerful typo-correction library. It contains hundreds of thousands of typo fixes. The library comes from another developer, so credit where it is due: https://github.com/platers/obsidian-linter/blob/master/src/utils/auto-correct-misspellings.ts
Copy link
Collaborator

@smeech smeech May 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"over 35,000" (210896 ÷ 6)

There are 5442 duplicate replacements, which could be reduced using the triggers: [] method, but that's probably asking too much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants