-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seeed multi channel relay control documentation #2840
Conversation
✅ Deploy Preview for esphome ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…ESPHome_doc_fork into Seeed_documentation
…ESPHome_doc_fork into Seeed_documentation
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
Documentation is ready for review |
------------------------ | ||
**Control** | ||
|
||
- **addres** (*Optional*, hex-address): This should only be added to change the i2c address |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is not intuitive.
How about to rename it to change_address_to
and run it always? So it will change address only when intended.
Or better create action for changing address? User can run it on startup or on button click.
Or be more verbose in docs what it exactly does and when it changes address.
I also miss info about the default address. This is from product page:
Default I2C Address: 0x11 or 0x12
Available I2C Address: 0x00 ~ 0x7F
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the default addresses and changed the name to change_address_to
Created new documentation, since this one was not correct. |
Description:
Related issue (if applicable): fixes
Pull request in esphome with YAML changes (if applicable): esphome/esphome#4684
Checklist:
I am merging into
next
because this is new documentation that has a matching pull-request in esphome as linked above.or
I am merging into
current
because this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.Link added in
/index.rst
when creating new documents for new components or cookbook.