Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seeed multi channel relay control documentation #2840

Closed
wants to merge 27 commits into from

Conversation

KoenBreeman
Copy link
Contributor

Description:

Related issue (if applicable): fixes

Pull request in esphome with YAML changes (if applicable): esphome/esphome#4684

Checklist:

  • I am merging into next because this is new documentation that has a matching pull-request in esphome as linked above.
    or

  • I am merging into current because this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.

  • Link added in /index.rst when creating new documents for new components or cookbook.

@netlify
Copy link

netlify bot commented Apr 14, 2023

Deploy Preview for esphome ready!

Name Link
🔨 Latest commit 9cb1001
🔍 Latest deploy log https://app.netlify.com/sites/esphome/deploys/66b5fc53fa75ff0008ffa820
😎 Deploy Preview https://deploy-preview-2840--esphome.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@KoenBreeman KoenBreeman changed the title Seeed documentation Seeed multi channel relay control documentation Apr 14, 2023
@github-actions
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jun 16, 2023
@github-actions github-actions bot closed this Jun 23, 2023
@nagyrobi nagyrobi reopened this Jun 23, 2023
@nagyrobi nagyrobi added not-stale and removed stale labels Jun 23, 2023
@KoenBreeman
Copy link
Contributor Author

Documentation is ready for review

------------------------
**Control**

- **addres** (*Optional*, hex-address): This should only be added to change the i2c address
Copy link
Contributor

@iBobik iBobik Mar 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is not intuitive.

How about to rename it to change_address_to and run it always? So it will change address only when intended.

Or better create action for changing address? User can run it on startup or on button click.

Or be more verbose in docs what it exactly does and when it changes address.

I also miss info about the default address. This is from product page:
Default I2C Address: 0x11 or 0x12
Available I2C Address: 0x00 ~ 0x7F

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the default addresses and changed the name to change_address_to

@KoenBreeman
Copy link
Contributor Author

KoenBreeman commented Aug 9, 2024

Created new documentation, since this one was not correct.
#4122

@KoenBreeman KoenBreeman closed this Aug 9, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants