Add model option for 2.66in-b in waveshare e-paper documentation #4501
Conversation
* Add Nextion actions * satisfy linter * add link to lambda section instead of providing examples * Apply suggestions from code review Co-authored-by: Keith Burzinski <kbx81x@gmail.com> * wrap lines --------- Co-authored-by: Keith Burzinski <kbx81x@gmail.com>
Co-authored-by: Samuel Sieb <samuel@sieb.net> Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
Co-authored-by: Samuel Sieb <samuel@sieb.net>
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
* Add docs for H-Bridge Switch * optimistic mode * Update hbridge.rst --------- Co-authored-by: Keith Burzinski <kbx81x@gmail.com>
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
WalkthroughThe documentation for the Changes
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (1)components/display/waveshare_epaper.rst (1)Pattern 🔇 Additional comments (1)components/display/waveshare_epaper.rst (1)
The new model Let's verify if this model requires any special configurations or warnings: ✅ Verification successfulModel addition looks good, no special handling required The 2.66in-b model follows the established conventions, and unlike some other models (gdew0154m09 and 7.50in V2) that require BUSY pin inversion, there are no special configurations or warnings needed for this model. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check if the new model requires special handling in the codebase
# Search for any special handling of the 2.66in-b model in the main codebase
rg -A 5 "2\.66in-b|GDEH0266B" $(fd -t f -e cpp -e h -e py)
# Search for any related issues or discussions
gh issue list --search "2.66in-b waveshare"
gh pr list --search "2.66in-b waveshare"
Length of output: 539 Script: #!/bin/bash
# Let's search for any special handling patterns similar to other B/W/R models
# First, find other B/W/R model references
rg "in-b.*Black/White/Red" components/display/
# Then check display component code for any special handling
rg -A 5 "busy_pin.*invert" components/display/
rg -A 5 "BUSY.*invert" components/display/
# Look for any model-specific configurations
rg "2\.66" components/display/
Length of output: 1272 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for esphome ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Add model option for 2.66in-b
|
I followed some instructions from chatGPT on how to rebase my PR to the next branch. But now, it looks like it's becoming quite a mess. |
Description:
Pull request in esphome with YAML changes (if applicable): esphome/esphome#7763
Checklist:
I am merging into
nextbecause this is new documentation that has a matching pull-request in esphome as linked above.or
I am merging into
currentbecause this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.Link added in
/index.rstwhen creating new documents for new components or cookbook.