-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for using BMP280 with SPI #7053
Conversation
Hey there @ademuri, CODEOWNERS = ["@ademuri"] And run (message by NeedsCodeownersLabel) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #7053 +/- ##
==========================================
+ Coverage 53.70% 53.93% +0.22%
==========================================
Files 50 50
Lines 9408 9678 +270
Branches 1654 1708 +54
==========================================
+ Hits 5053 5220 +167
- Misses 4056 4134 +78
- Partials 299 324 +25 ☔ View full report in Codecov by Sentry. |
51ade8f
to
4f1f14c
Compare
9dec67e
to
1399526
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please leave a minimal file in place at bmp280/__init__.py
and bmp280/sensor.py
similar to bmp3xx
Apologies for the spam, I accidentally rebased against the wrong dev branch. I did in fact apply all of the requested changes, but Github is showing one of them as outstanding. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple other quick remarks
🤦 Merging dev back in again after approval means I now have to wait for the CI to run again...haha |
This adds support for using BMP280 with SPI, similar to #5538.
What does this implement/fix?
This adds a
bmp280_spi
component, and moves the existingbmp280
component tobmp280_i2c
.Types of changes
Related issue or feature (if applicable): fixes esphome/feature-requests#1321.
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#4064
Test Environment
Example entry for
config.yaml
:Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed: